fix: changeset config stale package ref + E2E server connection filter + lockfile sync - #608
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ter server connection errors in E2E test Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
|
@copilot 12:06:20.973 Running build in Washington, D.C., USA (East) – iad1 |
|
@copilot 继续 |
…ove stale crm-app workspace entry Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Fixed in b15755b. The |
All fixes are already in place as of b15755b. The CI on this branch shows "action_required" (needs manual approval to run). Summary of fixes:
Verified locally: |
There was a problem hiding this comment.
Pull request overview
This PR addresses three critical CI/build failures on main by fixing stale configuration references, synchronizing the lockfile with the hotcrm submodule, and filtering expected E2E errors.
Changes:
- Fixed changeset config to reference renamed CLI package (
@objectstack/plugin-ui) - Added connection error filter to E2E bootstrap test for headless CI environments
- Regenerated lockfile to include 16 hotcrm submodule packages for Vercel builds
- Removed stale workspace entry for non-existent
examples/crm-appdirectory
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.changeset/config.json |
Updated package reference from @object-ui/cli to @objectstack/plugin-ui to match Phase 3.5 rename |
e2e/console-rendering.spec.ts |
Added "Failed to connect to ObjectStack server" to benign error filters for CI environments without backend |
pnpm-workspace.yaml |
Removed stale examples/crm-app entry (directory doesn't exist) |
pnpm-lock.yaml |
Added 16 hotcrm submodule package importers and updated dependency snapshots for Vercel compatibility |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Three CI/build failures on main: Changeset Release validation error, E2E bootstrap test, and Vercel build lockfile mismatch.
.changeset/config.json:@object-ui/cli→@objectstack/plugin-ui— the CLI package was renamed in P3.5 but the changesetfixedgroup wasn't updated, causingValidationError: The package or glob expression "@object-ui/cli" does not match any packagee2e/console-rendering.spec.ts: Add"Failed to connect to ObjectStack server"to the benign error filter in the bootstrap error test — no backend runs in CI, so this connection error is expected and should be ignored alongside existing MSW/favicon/network filterspnpm-lock.yaml: Regenerated with hotcrm submodule packages included — Vercel checks out submodules during clone (61 workspace projects), but the lockfile only had entries for 45 packages, causingERR_PNPM_OUTDATED_LOCKFILEon Vercel buildspnpm-workspace.yaml: Removed staleexamples/crm-appentry (directory doesn't exist)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.